IL-24401: Added message handler for webview #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexquintero
approved these changes
Aug 22, 2017
browser.js
Outdated
| chrome.runtime.getBackgroundPage(function (bg) { | ||
| chrome.runtime.getBackgroundPage(function(bg) { | ||
| window.bg = bg; | ||
| chrome.storage.local.get(null, settings_ready); |
There was a problem hiding this comment.
Do you want this to be storage.get? To simplify it as you've done elsewhere?
…e` to store settings with Chrome storage. Also added handler for opening external links in new browser tab.
ericgibby
force-pushed
the
message-handler
branch
from
ddb4546 to
fd7c00e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added listener to
chrome.runtime.onMessageExternalso the webview can use the Chrome messaging API for setting and retrieving application settings.Also added handler for opening external links in a new browser tab, since the app inside the webview now has links for the Privacy Policy and EULA which open PDFs in new tabs.